Update lombscargle.py #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @hamzaallen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-09-11 10:19:02 UTC |
matteobachetti
requested changes
Jul 2, 2024
There was a problem hiding this comment.
Thanks @hamzaallen! A very useful addition to Stingray!
To verify that the code works, it would be good to have one or more tests added to test_lombscargle.py.
In test_powerspectrum.py we have a few tests for the equivalent function in Powerspectrum and AveragedPowerspectrum, you can use those as templates.
Also, compute_rms does not have a docstring and we require all user-facing methods to be properly documented
|
|
||
|
|
||
|
|
||
| def compute_rms(self, min_freq, max_freq, poisson_noise_level=None): | ||
|
|
There was a problem hiding this comment.
Please add a docstring to the function
Define two functions that calculate the rms and rms error of the spectrum over a specific range of frequencies.
matteobachetti
force-pushed
the
patch-1
branch
from
072d4b4
to
6ac6dd5
Compare
Fixes, tests, and docstrings
matteobachetti
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define two functions that calculate the rms and rms error of the spectrum over a specific range of frequencies.
Relevant Issue(s)/PR(s)
Provide an overview of the implemented solution or the fix and elaborate on the modifications.
Is there a new dependency introduced by your contribution? If so, please specify.
Any other comments?