Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New JOSS paper draft #829

Merged
merged 32 commits into from
Oct 25, 2024
Merged

New JOSS paper draft #829

merged 32 commits into from
Oct 25, 2024

Conversation

matteobachetti
Copy link
Member

This PR adds a new paper we are submitting to JOSS. We had already a publication in 2019, and in this paper we describe all the improvements of the code in the last 5 years.
The paper is in paper2.md, the bibliography in joss2.bib

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.98%. Comparing base (ba8d06d) to head (c00a97c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #829   +/-   ##
=======================================
  Coverage   95.98%   95.98%           
=======================================
  Files          48       48           
  Lines        9686     9686           
=======================================
  Hits         9297     9297           
  Misses        389      389           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matteobachetti
Copy link
Member Author

Hello @abigailStev @jdswinbank @mgullik @matteolucchini1 @eleonorav89 @theand9 @Gaurav17Joshi @pupperemeritus @francescodoan @swapsha96 @mihirtripathi97 @dhruv9vats
This paper describes the work done since the first JOSS paper in 2019. You are listed as co-authors because you have given major contributions that are explicitly listed in the manuscript.
We need each of you to accept or decline explicitly the co-authorship, and give your affiliation and (if any) your OrcID number. And of course, feel free to comment on the manuscript!
Thanks in advance!

@eleonorav89
Copy link
Collaborator

Very nice job! Thank you @matteobachetti for including me :)

@pupperemeritus
Copy link
Contributor

Thank you @matteobachetti. I'd love to be a coauthor. 0009-0006-3745-5553 is my OrcID.

@matteolucchini1
Copy link
Collaborator

Hi @matteobachetti , I would be very happy to be a co-author, thanks for including me!

My current affiliation is "Anton Pannekoek Institute, University of Amsterdam, Science Park 904, 1098 XH Amsterdam, The Netherlands" and my OrcID is 0000-0002-2235-3347. Do you have a deadline for when you would like comments? I will be very busy the next two weeks, but I might find some time after COSPAR.

@francescodoan
Copy link
Contributor

Hello everyone!
Thank you @matteobachetti for including me in the coauthor list!

My Orcid: 0000-0003-0799-5760
My current affiliation is LIPN-Université Sorbonne Paris Nord.

Let me know if there is anything else I can do!

@Gaurav17Joshi
Copy link
Contributor

Thanks for the invite.I would be very happy to be a co-author. I am at Indian Institute of Technology Gandhinagar, and my ORCID ID is 0009-0009-2305-5008.

@matteobachetti
Copy link
Member Author

Thank you @matteobachetti. I'd love to be a coauthor. 0009-0006-3745-5553 is my OrcID.

what is your affiliation @pupperemeritus ?

@pupperemeritus
Copy link
Contributor

It's Chaitanya Bharathi Institute of Technology, Hyderabad,India.

@dhruv9vats
Copy link
Contributor

Thank you for the consideration!
I'd be more than happy to be a co-author @matteobachetti.

My current affiliation: Voltron Data, US, worldwide remote
My OrcID: 0009-0001-0542-0755

@mihirtripathi97
Copy link
Contributor

Hi @matteobachetti, Thank you for including me! I would love to be a co-author.

My current affiliation: Academia Sinica Institute of Astronomy & Astrophysics 11F of Astronomy-Mathematics Building, AS/NTU, No. 1, Section 4, Roosevelt Road, Taipei 10617, Taiwan, R.O.C.

My ORCID: 0009-0007-2723-0315

@swapsha96
Copy link
Contributor

Thanks, @matteobachetti. I accept the co-authorship. My affiliation is "Indian Institute of Technology, Mandi".

Copy link
Collaborator

@mgullik mgullik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @matteobachetti,
thanks for including me in this paper, I accept to be a co-author.
I left a few comments directly on the text.

joss/paper2.md Outdated Show resolved Hide resolved
joss/paper2.md Outdated Show resolved Hide resolved
joss/paper2.md Outdated
Recovery and Resilience Plan (NRRP) - Mission 4 Component 2 within the activities of Spoke 3
(Astrophysics and Cosmos Observations)
D.H. is supported by the Women In Science Excel (WISE) programme of the Netherlands Organisation for Scientific Research (NWO).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I may add my acknowledgments (it's not strictly necessary though )
G.M. acknowledges financial support from the European Union’s Horizon Europe research and innovation programme under the Marie Sk\l{}odowska-Curie grant agreement No. 101107057

joss/paper2.md Outdated

We introduced a wide range of new techniques particularly designed to analyse unevenly sampled data sets, responding to the growing need for these techniques with the advent of large-scale astronomical time domain surveys, subject to irregular observing constraints. Methods include Gaussian Process modeling of quasi-periodic oscillations [hubner] and Lomb-Scargle cross spectra [scargle]. We have introduced the Fourier-Domain Acceleration Search [ransom] for pulsars; the H-test [dejager] and Phase Dispersion Minimization [stellingwerf] statistics were also introduced into the pulsar sub package to evaluate the folded profiles of pulsars. We expanded the statistical capabilities of Stingray by introducing a number of statistical evaluation functions to estimate the statistics of periodograms, with particular attention to the upper limits on variable power.

Finally, we have added a number of high-level exploratory and diagnostic functionality specifically as an essential toolbox to characterize accreting compact objects during their outbursts: standard measures such as color-color and hardness-intensity diagrams, and their equivalent diagnostics in the frequency domain, "power colors" [@powercolors].
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"standard measures" -> "standard products"

@theand9
Copy link
Contributor

theand9 commented Jul 8, 2024

@matteobachetti Thank you so much for including me and recognizing my contributions!

ORCID: 0000-0002-6015-9553
Current Affiliation: Carnegie Mellon University

@matteobachetti
Copy link
Member Author

matteobachetti commented Sep 9, 2024

Comments from @masonng-astro :

  • Consistency between using “modelling” and “modeling”, except for the reference to the subpackage
  • “analyse” was written in the text instead of “analyze” (I assume the authors are adopting US English spelling throughout)
  • The hyperlinks to “our benchmarks” and “Lightkurve” point to wrong locations
  • I believe the authors will be adding the references before final approval

Ref: pyOpenSci/software-submission#201 (comment)

@matteobachetti
Copy link
Member Author

@JohannesBuchner I just realized that you should also be in this paper ;)
Could you confirm and give me your affiliation and ORCID?

@JohannesBuchner
Copy link

JohannesBuchner commented Sep 10, 2024

OK :)

0000-0003-0426-6634

Max Planck Institute for Extraterrestrial Physics, Giessenbachstrasse, 85741 Garching, Germany

no acks necessary

@matteobachetti matteobachetti marked this pull request as ready for review October 24, 2024 07:21
@matteobachetti matteobachetti added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit 137d17d Oct 25, 2024
5 checks passed
@matteobachetti matteobachetti deleted the update_joss_paper branch October 25, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.