Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update danger to the latest version 🚀 #1384

Closed
wants to merge 3 commits into from

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Aug 7, 2017

Version 1.2.0 of danger just got published.

Dependency danger
Current Version 0.18.0
Type devDependency

The version 1.2.0 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of danger.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.


Commits

The new version differs by 143 commits.

  • d182280 Release 1.2.0
  • 89374b9 Remove dtslint
  • cff9a36 Update VS Code recommendations
  • d94e009 Merge pull request #318 from danger/expose_contents
  • 09513d7 Use my TS Jest fork
  • 1f4d82e Updates Jest, and ts-jest - you never know
  • 25d0d11 Directly call jest
  • 2727a12 Add jest folder to travis cache
  • 6931599 Add back the jest caching
  • ff6e6e8 Update the DSL to expose a file contents API
  • b72dd6e Merge pull request #315 from danger/prettier_upgrade
  • 7d8528a Update prettier and add slack notifications in travis
  • 9582a66 Prepare for v1.1.0
  • 2cefe7d Merge pull request #311 from mlabrum/add-vsts-ci-support
  • c93cb4c Merge branch 'master' into add-vsts-ci-support

There are 143 commits in total.

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

@stodevx-bot
Copy link

stodevx-bot commented Aug 7, 2017

Fails
🚫

Running your Dangerfile has Failed

Danger has errored

Error: Error

Error: Cannot find module 'package.json'
    at Function.Module._resolveFilename (module.js:485:15)
    at Function.Module._load (module.js:437:25)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at getBabelRC (/home/travis/build/StoDevX/AAO-React-Native/node_modules/babel-jest/build/index.js:53:41)
    at Object.getCacheKey (/home/travis/build/StoDevX/AAO-React-Native/node_modules/babel-jest/build/index.js:90:14)
    at ScriptTransformer._getCacheKey (/home/travis/build/StoDevX/AAO-React-Native/node_modules/jest-runtime/build/ScriptTransformer.js:68:26)
    at ScriptTransformer._getFileCachePath (/home/travis/build/StoDevX/AAO-React-Native/node_modules/jest-runtime/build/ScriptTransformer.js:93:27)
    at ScriptTransformer.transformSource (/home/travis/build/StoDevX/AAO-React-Native/node_modules/jest-runtime/build/ScriptTransformer.js:182:32)
    at ScriptTransformer._transformAndBuildScript (/home/travis/build/StoDevX/AAO-React-Native/node_modules/jest-runtime/build/ScriptTransformer.js:275:40)

Generated by 🚫 dangerJS

@hawkrives
Copy link
Member

I have commented on the danger repo to ask about this.

@hawkrives hawkrives closed this Aug 7, 2017
@hawkrives
Copy link
Member

Apparently if we put a blank babelrc file in our project, jest behaves properly. (See danger/danger-js#261 (comment)).

@hawkrives hawkrives reopened this Aug 8, 2017
@hawkrives
Copy link
Member

Okay that really broke something

I'll look at this again later

@greenkeeper greenkeeper bot closed this Aug 11, 2017
@greenkeeper greenkeeper bot deleted the greenkeeper/danger-1.2.0 branch August 11, 2017 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants