Full doc review #133
Merged
Full doc review #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the sourced workspace is a ROS WS but not a RTW, the create a new pkg failed to find ros2 cli required for RTW functions
colcon_build_up_to required ROS_WS to be set otherwise builds in $HOME without error but subsequent suggested test commands fail.
gwalck
force-pushed
the
guillaume-doc-review
branch
from
fe39af8
to
35c2b60
Compare
|
This pull request is in conflict. Could you fix it @gwalck? |
destogl
previously approved these changes
Aug 1, 2023
destogl
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I performed a full doc review, including testing all the commands except the docker installation (Which I did in the past and will provide separate PR for)
The changes are either typo/grammar, or reStructured text fixes, or rephrasing for clarification, but some scripts were also changed to make them do what the doc said it should do (especially support running generator scripts inside a non-RTW workspace)