Update Script and Templates for Generating *.launch.xml Files #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamueluth
previously approved these changes
Feb 5, 2024
destogl
reviewed
Feb 21, 2024
destogl
previously approved these changes
Feb 21, 2024
destogl
previously approved these changes
Feb 21, 2024
destogl
reviewed
Feb 21, 2024
templates/ros2_control/test_forward_position_controller.launch.xml
Outdated
Show resolved
Hide resolved
templates/ros2_control/test_joint_trajectory_controller.launch.xml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant updates to the robot description and robot bring-up scripts. The primary change involves the generation of *.launch.xml files, which are set to replace the existing *.launch.py files. This update is motivated by the need for a more standardized and efficient approach to handling launch configurations.
Key Changes:
Updated Scripts: The scripts for robot description and robot bring-up have been modified to generate *.launch.xml files.
Template Modifications: To facilitate this transition, the existing templates have been revised. These updated templates now support the generation of *.launch.xml files while maintaining the same functionality as the previous *.launch.py files.
Enhanced Functionality: The move to *.launch.xml files is not merely a change in file format but also an enhancement in terms of scalability, readability, and ease of maintenance. This update paves the way for more complex configurations and simplifies the process of managing launch files.