Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bringup template #195

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Fix bringup template #195

merged 3 commits into from
Apr 8, 2024

Conversation

Nibanovic
Copy link
Contributor

Found a small issue when generating bringup package:

  • generated launch.xml file tries to load forward_position_controller as both active and inactive, causing crashes
  • JTC needs a default command and state_interfaces to be set so that it can be configured, even when loading it as inactive

@Nibanovic Nibanovic requested a review from destogl April 5, 2024 07:57
* so that setup-moveit-package planning and execution works out of the box
@Nibanovic Nibanovic self-assigned this Apr 5, 2024
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks!

@Nibanovic Nibanovic merged commit bfe94dd into master Apr 8, 2024
7 of 8 checks passed
@Nibanovic Nibanovic deleted the fix-bringup-template branch April 8, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants