Fix bug with self.final_answer_model in members.py to resolve model configuration inconsistencies #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix final_answer_model to use the model configuration provided by user to resolve issues with configuration inconsistency between members & final model Signed-off-by: Arun Cherla <kcherla@gmail.com>
StreetLamb
approved these changes
Sep 13, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix final_answer_model in members.py to use the model configuration provided by user to resolve issues with configuration inconsistency between member models & final model.
This resolves issues where a user may specify the ollama model or any model that requires custom parameters like "base_url" that fail to be properly configured in the final_answer_model object thus resulting in errors (potentially due to final_answer_model resolving the wrong model to be used or due to it using defaults due to missing parameter configurations).