-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make more declarations internal #196
Conversation
Once this is merged I'd say 1.0.0 is good to go. |
Looks good. Let me merge this one and release 1.0.0. I guess we can always expose something later, if needed |
@ftomassetti thanks! Yes, the idea is to close now, to open up later if necessary. |
@lppedd 1.0.0 should now be out! |
@ftomassetti just updated our projects to 1.0.0 and it's all good, thanks! |
Done: https://github.com/Strumenta/antlr-kotlin/releases/tag/1.0.0 |
Reasoning:
synchronized
: it's there because of a 1:1 translation from the Java runtime.I want to be free to swap it with kotlinx-atomicfu utilities at some point.
assert
: same reasoning assynchronized
. At some point the Kotlin stdlib will offer a proper multiplatform assert.Collections
: it's there because of a 1:1 translation from the Java runtime. I want to be able to get rid of it anytime.CopyOnWriteArrayList
,IdentityHashMap
,WeakHashMap
: internal details that might be changed anytime.