Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more declarations internal #196

Merged
merged 7 commits into from
Sep 6, 2024

Conversation

lppedd
Copy link
Contributor

@lppedd lppedd commented Sep 2, 2024

Reasoning:

  • synchronized: it's there because of a 1:1 translation from the Java runtime.
    I want to be free to swap it with kotlinx-atomicfu utilities at some point.
  • codepoint functions: we only use those functions in very specialized places, and making them internal means we can also make them inline.
  • assert: same reasoning as synchronized. At some point the Kotlin stdlib will offer a proper multiplatform assert.
  • Collections: it's there because of a 1:1 translation from the Java runtime. I want to be able to get rid of it anytime.
  • CopyOnWriteArrayList, IdentityHashMap, WeakHashMap: internal details that might be changed anytime.

@lppedd
Copy link
Contributor Author

lppedd commented Sep 2, 2024

Once this is merged I'd say 1.0.0 is good to go.
A GitHub Release (even without artifacts) could be useful to notify everyone that starred the repo.

@ftomassetti
Copy link
Member

Looks good. Let me merge this one and release 1.0.0. I guess we can always expose something later, if needed

@ftomassetti ftomassetti merged commit 8dd5d45 into Strumenta:master Sep 6, 2024
6 checks passed
@lppedd lppedd deleted the refactor/internal branch September 6, 2024 13:17
@lppedd
Copy link
Contributor Author

lppedd commented Sep 6, 2024

@ftomassetti thanks! Yes, the idea is to close now, to open up later if necessary.

@ftomassetti
Copy link
Member

@lppedd 1.0.0 should now be out!

@lppedd
Copy link
Contributor Author

lppedd commented Sep 6, 2024

@ftomassetti just updated our projects to 1.0.0 and it's all good, thanks!
I guess you could open a Release, otherwise tags don't come up in the GitHub feed.

@ftomassetti
Copy link
Member

@ftomassetti just updated our projects to 1.0.0 and it's all good, thanks! I guess you could open a Release, otherwise tags don't come up in the GitHub feed.

Done: https://github.com/Strumenta/antlr-kotlin/releases/tag/1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants