Update utf8 implementation #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO : fix the utf8 implementation to make this test pass :)
| @@ -738,7 +738,8 @@ var out = { | |||
| * This method will be removed in a future version without replacement. | |||
| */ | |||
| utf8encode: function (string) { | |||
| return utf8.utf8encode(string); | |||
| var array = utf8.utf8encode(string); | |||
| return utils.transformTo("string", array); | |||
There was a problem hiding this comment.
very minor point, but any reason you have the intermediate array here, instead of just nesting the function calls, as above?
There was a problem hiding this comment.
No reason, I'll update the commit.
|
💩 Cool! |
Thanks @puzrin for the hints :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces the utf8 implementation with the one from pako. This fixes #142.