forked from opensearch-project/OpenSearch-Dashboards
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "feat: make the pr smaller" #16
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 67.24% 67.31% +0.07%
==========================================
Files 3344 3350 +6
Lines 64792 64993 +201
Branches 10427 10468 +41
==========================================
+ Hits 43568 43752 +184
+ Misses 18683 18674 -9
- Partials 2541 2567 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
force-pushed
the
feature/validate-workspace-id-when-setup
branch
3 times, most recently
from
March 15, 2024 09:11
52672e1
to
9a9c39c
Compare
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
…ect#6168) Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
…lugin (opensearch-project#6185) * remove obsolete snapshots Signed-off-by: Lu Yu <nluyu@amazon.com> * add change log Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com>
…-project#6164) Application config plugin allows external plugin to register a different storage other than the default OpenSearch. The external plugin may need some additional information about the request headers when handling the requests. * Allow extra information in the application config calls Signed-off-by: Tianle Huang <tianleh@amazon.com> * only expose headers Signed-off-by: Tianle Huang <tianleh@amazon.com> * update jsdoc Signed-off-by: Tianle Huang <tianleh@amazon.com> * add more logs Signed-off-by: Tianle Huang <tianleh@amazon.com> * update change log Signed-off-by: Tianle Huang <tianleh@amazon.com> * update readme Signed-off-by: Tianle Huang <tianleh@amazon.com> * update readme Signed-off-by: Tianle Huang <tianleh@amazon.com> --------- Signed-off-by: Tianle Huang <tianleh@amazon.com>
…-project#6170) * [Discover] options button in canvas to toggle legacy mode Removes top nav bar link and provides a button option. Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
…ject#6178) * add version number to newly created datasource object Signed-off-by: Zilong Xia <zilongx@amazon.com> * update attribute key from version to dataSourceVersion Signed-off-by: Zilong Xia <zilongx@amazon.com> * add support and test coverage for custom auth type Signed-off-by: Zilong Xia <zilongx@amazon.com> * fix ciGroup3 test case suite Create Datasource Wizard Signed-off-by: Zilong Xia <zilongx@amazon.com> --------- Signed-off-by: Zilong Xia <zilongx@amazon.com> Signed-off-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
* Add set default datasource Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> * Fix typo Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> * change on this.props.isDefault Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> * add unit test Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> * set data_source to false Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> * add more unit test Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> * fix lint error Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> * edit one more unit test Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> * Fix another typo Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> --------- Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
opensearch-project#6175) * use filter function before rendering Signed-off-by: Lu Yu <nluyu@amazon.com> * add change log Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
…rch-project#6201) * updated follow redirects Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Adds changelog Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
…t#6123) * Add MDS support for Vega Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Refactor field to data_source_id Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Add to CHANGELOG.md Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Added test cases and renamed field to use data_source_name Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Add prefix datasource name test case and add example in default hjson Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Move CHANGELOG to appropriate section Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Increased test coverage of search() method Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Add test cases for util function Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Add util function to modify Vega Spec Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Add method to verify Vega saved object type Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Add import saved object support for Vega Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Add unit tests for Vega objects in create and conflict modes Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Refactored utils test file Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Add to CHANGELOG Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Use bulkget instead of single get Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Add datasource references to the specs Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Fix bootstrap errors Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Add edge case where title is potentially undefined Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Address PR comments Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Add more test coverage for checking conflict Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Fix unit test Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> --------- Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>
* add @xinruiba as a maintainer Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com> * update PR Id Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com> --------- Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe
force-pushed
the
feature/validate-workspace-id-when-setup
branch
from
March 20, 2024 03:08
cf4c84c
to
8350bef
Compare
Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9b66a28.
Description
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration