chore: change updateStrategy of the server and the registry #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thbcmlowk
requested changes
Sep 13, 2024
Comment on lines
15
to
16
| strategy: | ||
| type: Recreate |
There was a problem hiding this comment.
Wdyt of adding the field in the values file (just like the registry):
Suggested change
| strategy: | |
| type: Recreate | |
| strategy: | |
| type: {{ .Values.server.updateStrategy }} |
There was a problem hiding this comment.
I can make it configurable through the values if you think it's cleaner, I don't see any case where we wouldn't want to use the Recreate strategy since it's blocking the deployment because of the shared RWO PVC.
For the registry, we use an external chart, so we have to configure it through values.
No strong opinion in either direction though.
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
SdgJlbl
force-pushed
the
chore/change-updateStrategy
branch
from
a9fa6c1
to
2aeb34b
Compare
|
The default value seems to be Recreate, what this PR is changing? |
Default is |
thbcmlowk
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes FL-1733
Server and registry pods should no longer hang in pending because of race condition on RWO PVC.
Untested yet.