feat: add profiling step functions #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
SdgJlbl
reviewed
Apr 18, 2024
guilhem-barthes
force-pushed
the
feat/add-profiling-step-functions
branch
from
0887c24
to
115f0aa
Compare
guilhem-barthes
force-pushed
the
feat/add-profiling-step-functions
branch
from
49bb096
to
7b935bd
Compare
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
…o `orchestrator` Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
guilhem-barthes
force-pushed
the
feat/add-profiling-step-functions
branch
from
159819f
to
6beea40
Compare
guilhem-barthes
added a commit
to Substra/orchestrator
that referenced
this pull request
Jun 14, 2024
## Description <!-- Please reference issue if any. --> <!-- Please include a summary of your changes. --> Allow transferring function profiling steps through the orchestrator, allowing the builder to register event without having to have http(s) requests to the backend api server (involving having access to the db to get credentials). This also allows having duration for the function available on every backend. The drawback of this approach is, how it is relying on the event system already in place, the function profiling are also saved in the DB of the orchestrator. Fixes FL-1519 ## Companion PR - Substra/substra-backend#886 ## How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> ## Checklist - [ ] [changelog](../CHANGELOG.md) was updated with notable changes - [ ] documentation was updated --------- Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow transferring function profiling steps through the orchestrator, allowing the builder to register event without having to have http(s) requests to the backend api server (involving having access to the db to get credentials). This also allows having duration for the function available on every backend.
Still open on naming for the two new steps for the function. For now we have:
This does not include the API part for the frontend, which woudl be part of another task (FL-1518)
Fixes FL-1519
Companion PR
How has this been tested?
Checklist