Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make image builder timeout configurable #992

Merged
merged 8 commits into from
Sep 17, 2024

Conversation

guilhem-barthes
Copy link
Contributor

@guilhem-barthes guilhem-barthes commented Sep 2, 2024

Description

Fixes FL-1660

How has this been tested?

Checklist

  • changelog was updated with notable changes
  • documentation was updated

@guilhem-barthes
Copy link
Contributor Author

/e2e --tests sdk,substrafl,frontend,mnist,camelyon

@Owlfred
Copy link

Owlfred commented Sep 2, 2024

End to end tests: ✔️ SUCCESS

You rock!

Copy link

linear bot commented Sep 2, 2024

@guilhem-barthes guilhem-barthes force-pushed the feat/make-image-builder-timeout-configurable branch from c140143 to 3118966 Compare September 3, 2024 08:11
@guilhem-barthes
Copy link
Contributor Author

/e2e --tests sdk,substrafl,frontend,mnist,camelyon

@Owlfred
Copy link

Owlfred commented Sep 3, 2024

End to end tests: ✔️ SUCCESS

@guilhem-barthes
Copy link
Contributor Author

/e2e --tests doc

@Owlfred
Copy link

Owlfred commented Sep 3, 2024

End to end tests: ✔️ SUCCESS

@guilhem-barthes guilhem-barthes marked this pull request as ready for review September 3, 2024 08:55
@guilhem-barthes guilhem-barthes requested a review from a team as a code owner September 3, 2024 08:55
Copy link
Contributor

@SdgJlbl SdgJlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need a change fragment for the backend too? It's kind of a new feature...?

@guilhem-barthes guilhem-barthes force-pushed the feat/make-image-builder-timeout-configurable branch from 3cd0918 to 0f111a9 Compare September 4, 2024 08:37
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
…t custom named arguments

Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes guilhem-barthes force-pushed the feat/make-image-builder-timeout-configurable branch from 0f111a9 to 6d33e50 Compare September 17, 2024 14:33
@guilhem-barthes guilhem-barthes enabled auto-merge (squash) September 17, 2024 14:33
@guilhem-barthes guilhem-barthes merged commit 513842f into main Sep 17, 2024
10 checks passed
@guilhem-barthes guilhem-barthes deleted the feat/make-image-builder-timeout-configurable branch September 17, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants