Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove django-celery-results and replace by redis #995

Merged
merged 2 commits into from
Sep 17, 2024
Merged

feat: remove django-celery-results and replace by redis #995

merged 2 commits into from
Sep 17, 2024

Conversation

guilhem-barthes
Copy link
Contributor

Description

Fixes FL-1623

How has this been tested?

Checklist

  • changelog was updated with notable changes
  • documentation was updated

@linear Linear
Copy link

linear bot commented Sep 4, 2024

FL-1623 Drop Django-celery results

@guilhem-barthes
Copy link
Contributor Author

/e2e --tests sdk,substrafl,doc,mnist,camelyon

@Owlfred
Copy link

Owlfred commented Sep 4, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

@guilhem-barthes guilhem-barthes marked this pull request as ready for review September 10, 2024 09:59
@guilhem-barthes guilhem-barthes requested a review from a team as a code owner September 10, 2024 09:59
thbcmlowk
thbcmlowk approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@thbcmlowk thbcmlowk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🧹

@guilhem-barthes
Copy link
Contributor Author

/e2e --tests sdk,substrafl,doc,mnist,camelyon

@Owlfred
Copy link

Owlfred commented Sep 17, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

  • Camelyon / camelyon: ❌
  • Dispatch Jobs: ✔️
  • Documentation / doc: ❌
  • MNIST / mnist: ❌
  • SubstraFL / substrafl: ❌
  • SubstraSDK / sdk: ❌

Better luck next time!

@guilhem-barthes
Copy link
Contributor Author

/e2e --tests sdk,substrafl,doc,mnist,camelyon

@Owlfred
Copy link

Owlfred commented Sep 17, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

“To infinity and beyond!” ― Buzz Lightyear, Toy Story

@guilhem-barthes
feat: remove django-celery-results and replace by redis
3d8441e 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
doc: change fragment
62e3267 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes guilhem-barthes enabled auto-merge (squash) September 17, 2024 14:39
@guilhem-barthes guilhem-barthes merged commit 4021bf5 into main Sep 17, 2024
7 checks passed
@guilhem-barthes guilhem-barthes deleted the feat/remove-django-celery-results branch September 17, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thbcmlowk thbcmlowk thbcmlowk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guilhem-barthes @Owlfred @thbcmlowk