Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check computeplans before running function #997

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: check computeplans before running function #997

wants to merge 9 commits into from

Conversation

guilhem-barthes
Copy link
Contributor

@guilhem-barthes guilhem-barthes commented Sep 6, 2024 •
edited
Loading

Description

Fixes FL-1659

Companion PR

Checklist

  • changelog was updated with notable changes
  • documentation was updated

@guilhem-barthes
feat: add image_builder.check_function_is_runnable
478a868 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
feat: add tests
7801d7f 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@linear Linear
Copy link

linear bot commented Sep 6, 2024

FL-1659 Cancellation of CP while building functions

@guilhem-barthes
Copy link
Contributor Author

/e2e --tests sdk,substrafl,doc,mnist,frontend,camelyon

@Owlfred
Copy link

Owlfred commented Sep 6, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

  • Camelyon / camelyon,frontend: ✔️
  • Dispatch Jobs: ✔️
  • Documentation / doc: ✔️
  • MNIST / mnist,frontend: ✔️
  • SubstraFL / substrafl,frontend: ❌
  • SubstraSDK / sdk: ✔️

“It’s just a flesh wound.” ― The Black Knight, Monty Python and the Holy Grail

@guilhem-barthes
fix: add annotation to tests
01a10ca 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes guilhem-barthes force-pushed the feat/check-computeplans-before-running-function branch from 4506487 to 01a10ca Compare September 6, 2024 10:01
@guilhem-barthes
feat: change order which check CP status
a41e7ab 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
feat: add Function.cancel()
cfa490e 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
feat: add BuildCanceledError
695e3d8 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@github-actions github-actions bot added the api label Sep 9, 2024
@guilhem-barthes
fix: use real uuid in test_check_function_is_runnable
3fcdbe2 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
Copy link
Contributor Author

/e2e --tests sdk,substrafl,doc,mnist,frontend,camelyon --refs substra-tests=feat/check-computeplans-before-running-function

@Owlfred
Copy link

Owlfred commented Sep 9, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

Nailed it!

@guilhem-barthes
fix: db call on test_check_function_is_runnable
5513ea6 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes guilhem-barthes marked this pull request as ready for review September 10, 2024 09:42
@guilhem-barthes guilhem-barthes requested a review from a team as a code owner September 10, 2024 09:42
@guilhem-barthes
doc: change fragment
0073706 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes guilhem-barthes mentioned this pull request Sep 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guilhem-barthes @Owlfred