Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: remove type in dataset #405

Merged
merged 7 commits into from
Mar 25, 2024
Merged

chore!: remove type in dataset #405

merged 7 commits into from
Mar 25, 2024

Conversation

ThibaultFy
Copy link
Member

@ThibaultFy ThibaultFy commented Mar 22, 2024 •
edited
Loading

Related issue

closes FL-611

Companion

Notes

Please check if the PR fulfills these requirements

  • If necessary, the changelog has been updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The commit message follows the conventional commit specification
  • For any breaking changes, companion PRs have been opened on the following repositories:

@linear Linear
Copy link

linear bot commented Mar 22, 2024

FL-611 Remove dataset type field

@ThibaultFy
Copy link
Member Author

/e2e --tests substra,substrafl,doc --refs substrafl=rm-dataset-type,substra-tests=rm-dataset-type,substra-documentation=rm-dataset-type,substra=rm-dataset-type,substra-backend=rm-dataset-type

@Owlfred
Copy link

Owlfred commented Mar 22, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

“You shall not pass!” ― Gandalf, The Lord of the Rings, The Fellowship of the Ring

This was referenced Mar 22, 2024
Merged
Merged
Merged
Merged
@ThibaultFy
Copy link
Member Author

/e2e --tests sdk,mnist,camelyon --refs substrafl=rm-dataset-type,substra-tests=rm-dataset-type,substra-documentation=rm-dataset-type,substra=rm-dataset-type,substra-backend=rm-dataset-type

@Owlfred
Copy link

Owlfred commented Mar 22, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

It'll stay between us, no one needs to know.

@ThibaultFy
Copy link
Member Author

/e2e --tests sdk --refs substrafl=rm-dataset-type,substra-tests=rm-dataset-type,substra-documentation=rm-dataset-type,substra=rm-dataset-type,substra-backend=rm-dataset-type,orchestrator=rm-dataset-type

@Owlfred
Copy link

Owlfred commented Mar 22, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

“Boy, that escalated quickly.” ― Ron Burgundy, Anchorman: The Legend of Ron Burgundy

@ThibaultFy
Copy link
Member Author

/e2e --tests sdk --refs substrafl=rm-dataset-type,substra-tests=rm-dataset-type,substra-documentation=rm-dataset-type,substra=rm-dataset-type,substra-backend=rm-dataset-type,orchestrator=rm-dataset-type

@Owlfred
Copy link

Owlfred commented Mar 25, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

@ThibaultFy
rm type in dataset
8c7702a 
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@ThibaultFy
rm type in dataset
a5c886e 
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@ThibaultFy
rm type in dataset
ed31148 
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@ThibaultFy
rm type in dataset
51fa2b2 
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@ThibaultFy
rm type in dataset
bc30c79 
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@ThibaultFy ThibaultFy changed the title chore: remove type in dataset chore!: remove type in dataset Mar 25, 2024
@ThibaultFy
changelog
65b0c8a 
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@ThibaultFy
add gitkeep
8973972 
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@ThibaultFy ThibaultFy marked this pull request as ready for review March 25, 2024 15:58
@ThibaultFy ThibaultFy requested a review from a team as a code owner March 25, 2024 15:58
@ThibaultFy ThibaultFy mentioned this pull request Mar 25, 2024
Merged
@ThibaultFy
Copy link
Member Author

/e2e --tests substrafl,mnist,camelyon,doc --refs substrafl=rm-dataset-type,substra-tests=rm-dataset-type,substra-documentation=rm-dataset-type,substra=rm-dataset-type,substra-backend=rm-dataset-type,orchestrator=rm-dataset-type

@Owlfred
Copy link

Owlfred commented Mar 25, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

Crushed it!

@ThibaultFy ThibaultFy merged commit 3fb14fe into main Mar 25, 2024
5 checks passed
@ThibaultFy ThibaultFy deleted the rm-dataset-type branch March 25, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SdgJlbl SdgJlbl SdgJlbl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThibaultFy @Owlfred @SdgJlbl