Skip to content

Commit

Permalink
chore: drop Python 3.8 in CI
Browse files Browse the repository at this point in the history
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
  • Loading branch information
SdgJlbl committed Mar 12, 2024
1 parent f3870dc commit 1aaf701
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-22.04]
python: ["3.8", "3.9", "3.10", "3.11"]
python: ["3.9", "3.10", "3.11"]

steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: 3.11
- name: Install tools
run: pip install wheel
- name: Build
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/validate-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-22.04]
python: ["3.8", "3.9", "3.10", "3.11"]
python: ["3.9", "3.10", "3.11"]

steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -111,7 +111,7 @@ jobs:
steps:
- uses: actions/setup-python@v3
with:
python-version: 3.8
python-version: 3.11

- uses: actions/checkout@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/windows-subprocess-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
matrix:
os: [windows-latest]
python: ["3.8", "3.9", "3.10", "3.11"]
python: ["3.9", "3.10", "3.11"]

steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .readthedocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ formats: []

# Optionally set the version of Python and requirements required to build your docs
python:
version: 3.8
version: 3.11
install:
- requirements: docs/requirements.txt
2 changes: 1 addition & 1 deletion substrafl/remote/register/register.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

# minimal and maximal values of Python 3 minor versions supported
# we need to store this as integer, else "3.11" < "3.9" (string comparison)
MINIMAL_PYTHON_VERSION = 8 # 3.8
MINIMAL_PYTHON_VERSION = 9 # 3.9
MAXIMAL_PYTHON_VERSION = 11 # 3.11

_DEFAULT_BASE_DOCKER_IMAGE = "python:{python_version}-slim"
Expand Down
2 changes: 1 addition & 1 deletion tests/installable_library/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@
version="0.0.1",
description="testlib",
packages=find_packages(),
python_requires=">=3.8",
python_requires=">=3.9",
)
4 changes: 2 additions & 2 deletions tests/remote/register/test_register.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,13 @@ def add_function(*args):
pass


@pytest.mark.parametrize("version", ["2.7", "3.7", "3.18"])
@pytest.mark.parametrize("version", ["2.7", "3.7", "3.8", "3.18"])
def test_check_python_version(version):
with pytest.raises(UnsupportedPythonVersionError):
register._check_python_version(version)


@pytest.mark.parametrize("version", ["3.8", "3.9", "3.10", "3.11"])
@pytest.mark.parametrize("version", ["3.9", "3.10", "3.11"])
def test_check_python_version_valid(version):
"""Does not raise for supported versions"""
register._check_python_version(version)
Expand Down

0 comments on commit 1aaf701

Please sign in to comment.