Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(benchmark/camelyon): add new cli arguments #201

Merged
merged 2 commits into from
Mar 18, 2024
Merged

chore(benchmark/camelyon): add new cli arguments #201

merged 2 commits into from
Mar 18, 2024

Conversation

thbcmlowk
Copy link
Contributor

@thbcmlowk thbcmlowk commented Mar 18, 2024 •
edited
Loading

Companion

https://github.com/owkin/substra-ci/pull/150

Related issue

Closes FL-1500

Summary

Notes

Please check if the PR fulfills these requirements

  • If the feature has an impact on the user experience, the changelog has been updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The commit message follows the conventional commit specification

@thbcmlowk
chore(benchmark/camelyon): add new cli arguments
352c8cf 
Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
@thbcmlowk thbcmlowk marked this pull request as ready for review March 18, 2024 14:06
@thbcmlowk thbcmlowk requested a review from a team as a code owner March 18, 2024 14:06
ThibaultFy
ThibaultFy approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments, LGTM :)

CHANGELOG.md Outdated Show resolved Hide resolved
benchmark/camelyon/workflows.py Show resolved Hide resolved
@linear Linear
Copy link

linear bot commented Mar 18, 2024

FL-1500 Add CLI arguments to substrafl Camelyon benchmark

guilhem-barthes
guilhem-barthes reviewed Mar 18, 2024
View reviewed changes
Copy link
Contributor

@guilhem-barthes guilhem-barthes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! Just really small typing comments

benchmark/camelyon/workflows.py Outdated Show resolved Hide resolved
benchmark/camelyon/workflows.py Outdated Show resolved Hide resolved
@thbcmlowk
docs(benchmark/camelyon): update CHANGELOG and README
0ffe356 
Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
@thbcmlowk thbcmlowk merged commit 9fd2bb7 into main Mar 18, 2024
6 checks passed
@thbcmlowk thbcmlowk deleted the chore/camelyon-update branch March 18, 2024 15:04
@thbcmlowk thbcmlowk restored the chore/camelyon-update branch March 18, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilhem-barthes guilhem-barthes guilhem-barthes left review comments

@ThibaultFy ThibaultFy ThibaultFy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thbcmlowk @guilhem-barthes @ThibaultFy