chore: support Python 3.12 #226
Conversation
SdgJlbl
force-pushed
the
chore/python3.12
branch
from
5301a4c
to
4bd3026
Compare
SdgJlbl
force-pushed
the
chore/python3.12
branch
5 times, most recently
from
748c669
to
ab17af2
Compare
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
SdgJlbl
force-pushed
the
chore/python3.12
branch
3 times, most recently
from
0921c2d
to
066a66e
Compare
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
SdgJlbl
force-pushed
the
chore/python3.12
branch
from
066a66e
to
64d354d
Compare
SdgJlbl
force-pushed
the
chore/python3.12
branch
from
64d354d
to
01de09b
Compare
| @@ -109,7 +109,7 @@ jobs: | |||
| steps: | |||
| - uses: actions/setup-python@v5 | |||
| with: | |||
| python-version: 3.11 | |||
| python-version: 3.12 | |||
There was a problem hiding this comment.
Shouldn't we rather rely on a python matrix there too?
There was a problem hiding this comment.
You mean, running the benchmark with all versions of Python?
I guess it wasn't done for cost effectiveness reasons, but it can be changed, indeed.
There was a problem hiding this comment.
Yes, that's what I meant! (cf: comment on benchmark requirements)
SdgJlbl
force-pushed
the
chore/python3.12
branch
from
01de09b
to
ac7692a
Compare
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
SdgJlbl
force-pushed
the
chore/python3.12
branch
from
ac7692a
to
d67e0bc
Compare
|
/e2e --tests=substrafl,sdk,mnist,camelyon |
|
End to end tests: ✔️ SUCCESS Awesome sauce! |
| "substra~=0.54.0a1", | ||
| "substratools~=0.22.0a2", |
There was a problem hiding this comment.
To recap:
substratoolsin its alpha version is needed because we pip install it in the docker templatesubstrain its alpha version is needed because?
There was a problem hiding this comment.
I can try to make it work without the alphas, if we think it's worth it to invest the extra time 🤷
There was a problem hiding this comment.
My understanding is that we do need the substratools release for the python setup in docker. I would like to understand why do we need the substra pre-release. If you don't know it's ok, feel free to resolve the comment.
| @@ -109,7 +109,7 @@ jobs: | |||
| steps: | |||
| - uses: actions/setup-python@v5 | |||
| with: | |||
| python-version: 3.11 | |||
| python-version: 3.12 | |||
There was a problem hiding this comment.
Yes, that's what I meant! (cf: comment on benchmark requirements)
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
No description provided.