Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask if users want to be in a research panel #16

Merged
merged 5 commits into from
Jul 20, 2022

Conversation

BryceStevenWilley
Copy link
Contributor

@BryceStevenWilley BryceStevenWilley commented Jul 20, 2022

Saves their email and when they responded in a Redis ZSet, which can be viewed in the
browse_feedback_sessions interview. Is completely separate from session linking,
though I added the feature to view panelists behind the browse_feedback_session.yml.
Fixes #8.

Also makes a few small changes to previous features (#15, #9):

  • moves configuration options under the github issues key, so all of the related keys are together.
  • changes the name of the overridable github_label to al_github_label to match the other variables that
    can be overriden.

Finally, I added the above features to the README, and cleaned it up a bit (not ending spaces, etc.)

Saves their email in a Redis Set, which can be viewed in the
browse_feedback_sessions interview
README.md Outdated Show resolved Hide resolved
Co-authored-by: Quinten Steenhuis <qsteenhuis@gmail.com>
Only adds the email, as we shouldn't link their feedback to their identity at all.
"""
red = DARedis()
red.sadd(redis_panel_emails_key, email)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick suggestion: can we add the date as well? It may be helpful to filter panels by how recently they volunteered.

Copy link
Member

@nonprofittechy nonprofittechy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only thought is to add the date user volunteers, but that's not a blocker. Will let you merge when you're ready.

Allows us to save the time the user responded along with their email, so we can
get more recent respondants (who will be more likely to accept a follow up
interview than respondants who filled out their survey months or years ago).
@BryceStevenWilley BryceStevenWilley merged commit c2dc4bc into main Jul 20, 2022
@BryceStevenWilley BryceStevenWilley deleted the ask_research_panel branch July 20, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ask if the user would like to be a part of a "research panel"
2 participants