-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ask if users want to be in a research panel #16
Conversation
Saves their email in a Redis Set, which can be viewed in the browse_feedback_sessions interview
Co-authored-by: Quinten Steenhuis <qsteenhuis@gmail.com>
Only adds the email, as we shouldn't link their feedback to their identity at all. | ||
""" | ||
red = DARedis() | ||
red.sadd(redis_panel_emails_key, email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick suggestion: can we add the date as well? It may be helpful to filter panels by how recently they volunteered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only thought is to add the date user volunteers, but that's not a blocker. Will let you merge when you're ready.
Allows us to save the time the user responded along with their email, so we can get more recent respondants (who will be more likely to accept a follow up interview than respondants who filled out their survey months or years ago).
Saves their email and when they responded in a Redis ZSet, which can be viewed in the
browse_feedback_sessions interview. Is completely separate from session linking,
though I added the feature to view panelists behind the
browse_feedback_session.yml
.Fixes #8.
Also makes a few small changes to previous features (#15, #9):
github issues
key, so all of the related keys are together.github_label
toal_github_label
to match the other variables thatcan be overriden.
Finally, I added the above features to the README, and cleaned it up a bit (not ending spaces, etc.)