Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start creating 2.0.0 release #38

Closed
wants to merge 13 commits into from
Closed

Start creating 2.0.0 release #38

wants to merge 13 commits into from

Conversation

cddude229
Copy link
Contributor

  1. Upgrades as many things as possible (except jline - that's a bigger effort)
  2. Drop support for Java 6/7
  3. Some general cleaning
  4. Changes versions to 2.0.0-SNAPSHOT

Future changes:

  1. Switch to Gradle, which allows cross-compiling on 2.11 and 2.12
  2. Switch artifact names to end in _${scala.version.major} which is the industry standard

@cddude229 cddude229 requested a review from mccartney July 5, 2019 18:44
@mccartney
Copy link
Contributor

mccartney commented Jul 9, 2019 •
edited
Loading

There's some java.lang.NoClassDefFoundError: javax/tools/ToolProvider in Travis build.

Is it scala/bug#10603?

mccartney
mccartney approved these changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@mccartney mccartney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd fix the Travis build - not necessarily in the same PR.

@mccartney mccartney assigned cddude229 and unassigned mccartney Jul 9, 2019
@cddude229
Copy link
Contributor Author

Declaring this defunct and will redo the work from scratch.

@cddude229 cddude229 closed this Mar 23, 2021
@cddude229 cddude229 deleted the chris-dependency-updates branch March 23, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mccartney mccartney mccartney approved these changes

Assignees

@cddude229 cddude229

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cddude229 @mccartney