Skip to content

Commit

Permalink
ci: don't run unnecessary integration tests
Browse files Browse the repository at this point in the history
Passing TEST_NAME to the integration test runner just passes that value
verbatim to go test. The value in go test is a regular expression though
, so if we have a test whose name is a prefix of another test,
both will be run.

We were running the FIPS test alongside the default test every time
because of this.
  • Loading branch information
Mikołaj Świątek committed Mar 24, 2023
1 parent 7a360d7 commit 04a45e0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/pull_requests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ jobs:
${{ runner.os }}-go-integration-
- name: Run integration test - ${{ matrix.test_name }}
working-directory: ./tests/integration/
run: make test TEST_NAME=${{matrix.test_name}} KIND_NODE_IMAGE=${{matrix.kind_image}}
run: make test TEST_NAME=^${{matrix.test_name}}$ KIND_NODE_IMAGE=${{matrix.kind_image}}

integration-test-status:
runs-on: ubuntu-20.04
Expand Down

0 comments on commit 04a45e0

Please sign in to comment.