feat(metrics)!: disable remote write proxy access logs by default

.changelog/3071.breaking.txt

@@ -0,0 +1,3 @@
+feat(metrics)!: disable remote write proxy access logs by default
+
+The logs can be enabled by setting `sumologic.metrics.remoteWriteProxy.config.enableAccessLogs` to `true`.

deploy/helm/sumologic/README.md

@@ -95,7 +95,7 @@ The following table lists the configurable parameters of the Sumo Logic chart an
 | `sumologic.metrics.remoteWriteProxy.enabled`                                     | Enable a load balancing proxy for Prometheus remote writes. [See docs/best-practices.md for more information.](/docs/best-practices.md)                                                                                                                                                                                                                              | `true`                                                                                                                                                                               |
 | `sumologic.metrics.remoteWriteProxy.config.clientBodyBufferSize`                 | See the [nginx documentation](http://nginx.org/en/docs/http/ngx_http_core_module.html#client_body_buffer_size). Increase if you've also increased samples per send in Prometheus remote write.                                                                                                                                                                       | `64k`                                                                                                                                                                                |
 | `sumologic.metrics.remoteWriteProxy.config.workerCountAutotune`                  | This feature autodetects how much CPU is assigned to the nginx instance and setsthe right amount of workers based on that. Disable to use the default of 8 workers.                                                                                                                                                                                                  | `true`                                                                                                                                                                               |
-| `sumologic.metrics.remoteWriteProxy.config.enableAccessLogs`                     | Enable nginx access logs.                                                                                                                                                                                                                                                                                                                                            | `true`                                                                                                                                                                               |
+| `sumologic.metrics.remoteWriteProxy.config.enableAccessLogs`                     | Enable nginx access logs.                                                                                                                                                                                                                                                                                                                                            | `false`                                                                                                                                                                               |
 | `sumologic.metrics.remoteWriteProxy.replicaCount`                                | Number of replicas in the remote write proxy deployment.                                                                                                                                                                                                                                                                                                             | `3`                                                                                                                                                                                  |
 | `sumologic.metrics.remoteWriteProxy.image`                                       | Nginx docker image for the remote write proxy.                                                                                                                                                                                                                                                                                                                       | `{"repository": "public.ecr.aws/sumologic/nginx-unprivileged", "tag": "1.23.3-alpine", "pullPolicy": "IfNotPresent"}`                                                                |
 | `sumologic.metrics.remoteWriteProxy.resources`                                   | Resource requests and limits for the remote write proxy container.                                                                                                                                                                                                                                                                                                   | `{"limits": {"cpu": "1000m", "memory": "256Mi"}, "requests": {"cpu": "100m", "memory": "128Mi"}}`                                                                                    |

deploy/helm/sumologic/values.yaml

@@ -468,7 +468,7 @@ sumologic:
         ## Nginx listen port
         port: 8080
         ## Nginx access logs
-        enableAccessLogs: true
+        enableAccessLogs: false
       replicaCount: 3
       image:
         repository: public.ecr.aws/sumologic/nginx-unprivileged

tests/helm/testdata/goldenfile/remote_write_proxy/full_configmap.input.yaml

@@ -5,4 +5,4 @@ sumologic:
       config:
         clientBodyBufferSize: "32k"
         port: 80
-        enableAccessLogs: false
+        enableAccessLogs: true

tests/helm/testdata/goldenfile/remote_write_proxy/full_configmap.output.yaml

@@ -17,7 +17,6 @@ data:
 
     server {
         listen 80 default_server;
-        access_log off;
         location / {
             client_body_buffer_size 32k;
             proxy_pass http://remote;