Skip to content

Commit

Permalink
fix(metrics-server): add double dashes to extra arguments
Browse files Browse the repository at this point in the history
  • Loading branch information
kasia-kujawa committed Jun 29, 2023
1 parent 5f358b1 commit def1c8f
Show file tree
Hide file tree
Showing 4 changed files with 90 additions and 2 deletions.
1 change: 1 addition & 0 deletions .changelog/3109.fixed.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
fix(metrics-server): add double dashes to extra arguments
4 changes: 2 additions & 2 deletions deploy/helm/sumologic/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1231,8 +1231,8 @@ metrics-server:
apiService:
create: true
extraArgs:
- kubelet-insecure-tls=true
- kubelet-preferred-address-types=InternalIP,ExternalIP,Hostname
- --kubelet-insecure-tls=true
- --kubelet-preferred-address-types=InternalIP,ExternalIP,Hostname
## Optionally specify image options for metrics-server
# image:
## Optionally specify an array of imagePullSecrets.
Expand Down
2 changes: 2 additions & 0 deletions tests/helm/testdata/goldenfile/metric-server/basic.input.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
metrics-server:
enabled: true
85 changes: 85 additions & 0 deletions tests/helm/testdata/goldenfile/metric-server/basic.output.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
# Source: sumologic/charts/metrics-server/templates/deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
name: RELEASE-NAME-metrics-server
namespace: "sumologic"
labels:
app.kubernetes.io/name: metrics-server
helm.sh/chart: metrics-server-6.2.4
app.kubernetes.io/instance: RELEASE-NAME
app.kubernetes.io/managed-by: Helm
spec:
replicas: 1
selector:
matchLabels:
app.kubernetes.io/name: metrics-server
app.kubernetes.io/instance: RELEASE-NAME
strategy:
type: RollingUpdate
template:
metadata:
labels:
app.kubernetes.io/name: metrics-server
helm.sh/chart: metrics-server-6.2.4
app.kubernetes.io/instance: RELEASE-NAME
app.kubernetes.io/managed-by: Helm
spec:
serviceAccountName: RELEASE-NAME-metrics-server
affinity:
podAffinity:

podAntiAffinity:
preferredDuringSchedulingIgnoredDuringExecution:
- podAffinityTerm:
labelSelector:
matchLabels:
app.kubernetes.io/name: metrics-server
app.kubernetes.io/instance: RELEASE-NAME
topologyKey: kubernetes.io/hostname
weight: 1
nodeAffinity:

dnsPolicy: ClusterFirst
containers:
- name: metrics-server
image: docker.io/bitnami/metrics-server:0.6.2-debian-11-r0
imagePullPolicy: "IfNotPresent"
securityContext:
readOnlyRootFilesystem: false
runAsNonRoot: true
runAsUser: 1001
command:
- metrics-server
args:
- --secure-port=8443
- --kubelet-insecure-tls=true
- --kubelet-preferred-address-types=InternalIP,ExternalIP,Hostname
env:
envFrom:
resources:
limits: {}
requests: {}
ports:
- name: https
containerPort: 8443
livenessProbe:
failureThreshold: 3
initialDelaySeconds: 0
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 1
httpGet:
path: /livez
port: https
scheme: HTTPS
readinessProbe:
failureThreshold: 3
initialDelaySeconds: 0
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 1
httpGet:
path: /readyz
port: https
scheme: HTTPS

0 comments on commit def1c8f

Please sign in to comment.