Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A specific parameter for additional remote writes #1480

Closed
abjrcode opened this issue Mar 5, 2021 · 5 comments · Fixed by #2611
Closed

A specific parameter for additional remote writes #1480

abjrcode opened this issue Mar 5, 2021 · 5 comments · Fixed by #2611
Assignees
Labels
breaking-change priority:high question Further information is requested
Milestone

Comments

@abjrcode
Copy link

abjrcode commented Mar 5, 2021

Why is it not possible to add additional remoteWrites just like it is the case for additionalServiceMonitors?

The documentation on scraping additional services now points to the prometheus-overrides.yaml file, but that is error prone as I need to (possibly) re-generate it on chart updates?

Basically it would be nice to add additional monitors and remote writes without touching the ones provided by Sumo (just augmenting them).

@abjrcode abjrcode added the question Further information is requested label Mar 5, 2021
@abjrcode
Copy link
Author

abjrcode commented Mar 5, 2021

Something to consider, I and probably most others implement this with GitOps and want to avoid running any commands manually if possible.

@perk-sumo
Copy link
Contributor

perk-sumo commented Mar 5, 2021

Hi, the reason for that is because the Kube Prometheus Stack subchart we use doesn't provide such possibility - there is only one section for the remoteWrite to be used:
https://github.com/prometheus-community/helm-charts/blob/kube-prometheus-stack-12.3.0/charts/kube-prometheus-stack/values.yaml#L1943

We know it's not ideal.

@abjrcode
Copy link
Author

abjrcode commented Mar 7, 2021

Thanks for the clarification. Wouldn't be possible that you expose this as a parameter on your own chart and then merge the result when passing it to the subchart?

@sumo-drosiek
Copy link
Contributor

Wouldn't be possible that you expose this as a parameter on your own chart and then merge the result when passing it to the subchart?

We are not aware of possibility to do that and keep everything clean and simple

We created PR in the kube-prometheus-stack helm chart, so maybe we will be able to do it in a proper way 🤞

@sumo-drosiek
Copy link
Contributor

labeling as breaking-change, because it requires updating the Prometheus CRDs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change priority:high question Further information is requested
Projects
None yet
4 participants