Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CRI log format #758

Closed
djsly opened this issue Jul 3, 2020 · 2 comments · Fixed by #950
Closed

Support CRI log format #758

djsly opened this issue Jul 3, 2020 · 2 comments · Fixed by #950
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@djsly
Copy link
Contributor

djsly commented Jul 3, 2020

Containerd does not support JSON format, and AKS is moving away from Moby to use instead Containerd.

To ensure that the sumologic collection solution still works, we would need that it supports CRI logging format out of the box.

Containerd sets up logging using the standardized cri logging format (which is different from what you currently get from docker’s json driver). Your logging solution needs to support the cri logging format (like Azure Monitor for Containers)

As noted: https://docs.microsoft.com/en-us/azure/aks/cluster-configuration#containerd-limitationsdifferences

@perk-sumo
Copy link
Contributor

Hi @djsly - thank you for this issue, we'll definitely look on how to support CRI logs!
/cc @frankreno

@frankreno frankreno added the enhancement New feature or request label Jul 8, 2020
@frankreno frankreno modified the milestones: v1.2, v1.3 Jul 8, 2020
@frankreno
Copy link
Contributor

When implementing - make sure you review fluent/fluent-bit#1316

@vsinghal13 vsinghal13 linked a pull request Sep 24, 2020 that will close this issue
3 tasks
@vsinghal13 vsinghal13 self-assigned this Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants