Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add crio parser to fluent-bit #950

Merged
merged 3 commits into from
Sep 25, 2020
Merged

add crio parser to fluent-bit #950

merged 3 commits into from
Sep 25, 2020

Conversation

vsinghal13
Copy link
Contributor

@vsinghal13 vsinghal13 commented Sep 24, 2020 •
edited
Loading

Description

The default cri parser defined in fluent-bit uses message as the key, instead of log. This PR defines a custom crio parser which uses the log key instead, so that the Sumo Logic apps do not break.

image (24)
Example of CRIformat log with message key attached.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@vsinghal13 vsinghal13 requested review from a team, samjsong, pmalek-sumo, andrzej-stencel and frankreno and removed request for a team September 24, 2020 20:39
@vsinghal13 vsinghal13 added this to the v1.3 milestone Sep 24, 2020
@vsinghal13 vsinghal13 requested review from perk-sumo and removed request for samjsong September 24, 2020 20:40
@vsinghal13 vsinghal13 linked an issue Sep 24, 2020 that may be closed by this pull request
Support CRI log format #758
Closed
sumo-drosiek
sumo-drosiek approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Do we have an example log from the cri?

perk-sumo
perk-sumo approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vsinghal13 vsinghal13 merged commit 1301447 into master Sep 25, 2020
@vsinghal13 vsinghal13 deleted the vsinghal13-add-crio-parser branch September 25, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perk-sumo perk-sumo perk-sumo approved these changes

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@pmalek-sumo pmalek-sumo Awaiting requested review from pmalek-sumo

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel

@frankreno frankreno Awaiting requested review from frankreno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Support CRI log format
3 participants
@vsinghal13 @sumo-drosiek @perk-sumo