Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thanos sidecar has no limits set #862

Closed
perk-sumo opened this issue Aug 28, 2020 · 3 comments · Fixed by #874
Closed

Thanos sidecar has no limits set #862

perk-sumo opened this issue Aug 28, 2020 · 3 comments · Fixed by #874
Assignees
Labels
bug Something isn't working
Milestone

Comments

@perk-sumo
Copy link
Contributor

On of containers is not limited by default - and it should be as sumo warns about not-limited containers.

Container name: thanos-sidecar
StatefulSet name: prometheus-collection-prometheus-oper-prometheus
Helm chart version affected: all

@perk-sumo perk-sumo added this to the v1.3 milestone Aug 28, 2020
@perk-sumo
Copy link
Contributor Author

There are no limits for thanos in the prometheus-operator values: https://github.com/helm/charts/blob/master/stable/prometheus-operator/values.yaml#L1961

@vsinghal13
Copy link
Contributor

vsinghal13 commented Aug 28, 2020

User can set it as follows:
https://github.com/prometheus-operator/prometheus-operator/blob/master/Documentation/api.md#thanosspec

prometheus-operator:
  prometheus:
    prometheusSpec:
      thanos:
        resources: {}

@vsinghal13 vsinghal13 linked a pull request Aug 31, 2020 that will close this issue
3 tasks
@perk
Copy link
Contributor

perk commented Sep 1, 2020

Yeah, the thing is:

  1. sumo k8s app warns about not-limited containers
  2. thanos sidecar is not limited by default in the upstream chart like others

So you install the collection and instantly get the warning about collection, that's not a good experience.

@perk-sumo perk-sumo added the bug Something isn't working label Sep 4, 2020
@vsinghal13 vsinghal13 self-assigned this Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants