Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

define resources for thanos sidecar #874

Merged
merged 4 commits into from
Sep 14, 2020
Merged

define resources for thanos sidecar #874

merged 4 commits into from
Sep 14, 2020

Conversation

vsinghal13
Copy link
Contributor

@vsinghal13 vsinghal13 commented Aug 31, 2020 •
edited
Loading

Description

Solves #862
Ref: https://github.com/prometheus-operator/prometheus-operator/blob/master/Documentation/api.md#thanosspec

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@vsinghal13 vsinghal13 added this to the v1.3 milestone Aug 31, 2020
@vsinghal13 vsinghal13 linked an issue Aug 31, 2020 that may be closed by this pull request
Thanos sidecar has no limits set #862
Closed
perk
perk suggested changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@perk perk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add the limits by ourselves as the upstream chart is not limited.

perk-sumo
perk-sumo suggested changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add the limits by ourselves as the upstream chart is not limited.

@perk-sumo perk-sumo force-pushed the vsinghal13-thanos-resources branch from efcba0a to c31a418 Compare September 3, 2020 12:09
@perk-sumo perk-sumo force-pushed the vsinghal13-thanos-resources branch from df91080 to 5321ad3 Compare September 4, 2020 10:25
@vsinghal13
Copy link
Contributor Author

Thanks @perk-sumo for adding the limits.

perk-sumo
perk-sumo approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vsinghal13 vsinghal13 merged commit a843f99 into master Sep 14, 2020
@vsinghal13 vsinghal13 deleted the vsinghal13-thanos-resources branch September 14, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perk perk perk requested changes

@perk-sumo perk-sumo perk-sumo approved these changes

@samjsong samjsong Awaiting requested review from samjsong

@frankreno frankreno Awaiting requested review from frankreno

@sumo-drosiek sumo-drosiek Awaiting requested review from sumo-drosiek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Thanos sidecar has no limits set
3 participants
@vsinghal13 @perk @perk-sumo