move _origin to meta tag #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samjsong
approved these changes
Apr 11, 2019
rvmiller89
approved these changes
Apr 11, 2019
| @@ -72,7 +72,7 @@ def to_carbon_line(record) | |||
| metric = @metric_accessor.call(record).gsub(/\s/, @space_as) | |||
| timestamp = @timestamp_accessor.call(record) | |||
| value = @value_accessor.call(record) | |||
| "metric=#{metric} #{to_tags(record)} #{value} #{timestamp}" | |||
| "metric=#{metric} #{to_tags(record)} #{ORIGIN_KEY}=#{ORIGIN_VALUE} #{value} #{timestamp}" | |||
There was a problem hiding this comment.
LGTM, although I think we determined we could also just change this to
metric=#{metric} #{to_tags(record)} #{value} #{timestamp}
(2 spaces)
There was a problem hiding this comment.
yes. it should also works.
We may change it to Prometheus format in near future, so just keep it for now to unblock E2E
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
Re-create collectors for the search log2es app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
_orgin=kubernetesas a meta tag so we can workaround the 2 or 3 spaces problem for now.We may move to prometheus format later for resolving the whitespace in tag
@samjsong @rvmiller89 @lei-sumo