Add known k8s api callers to vagrant values.yaml and upgrade falco chart to 1.5.0 #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek-sumo
requested review from
sumo-drosiek,
perk-sumo and
andrzej-stencel
perk-sumo
reviewed
Oct 14, 2020
| rules_user_known_k8s_api_callers.yaml: |- | ||
| - macro: user_known_contact_k8s_api_server_activities | ||
| condition: > | ||
| (proc.pcmdline = "fluentd /usr/local/bundle/bin/fluentd -c /fluentd/etc/fluent.conf -p /fluentd/plugins") or |
There was a problem hiding this comment.
Can we use both proc names and the namespace?
There was a problem hiding this comment.
We could but we'd need to template it because user can configure the destination template for our collection?
There was a problem hiding this comment.
For vagrant env for now hardcoding should be fine though
perk-sumo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1.4.0to1.5.0(this bumps falco from0.25.0to0.26.1)Testing performed