Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable FluentD file persistence by default #1033

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Enable FluentD file persistence by default #1033

merged 2 commits into from
Oct 23, 2020

Conversation

vsinghal13
Copy link
Contributor

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@vsinghal13 vsinghal13 requested review from frankreno, perk-sumo, a team and samjsong and removed request for a team October 22, 2020 17:15
@vsinghal13 vsinghal13 added this to the v2.0 milestone Oct 22, 2020
perk-sumo
perk-sumo approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@perk-sumo perk-sumo changed the title enable file persistence by default Enable FluentD file persistence by default Oct 23, 2020
@perk-sumo perk-sumo merged commit 1be37e1 into master Oct 23, 2020
@perk-sumo perk-sumo deleted the vsinghal13-enable-file-persistence-default branch October 23, 2020 13:43
@pmalek-sumo pmalek-sumo mentioned this pull request Dec 16, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perk-sumo perk-sumo perk-sumo approved these changes

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@frankreno frankreno Awaiting requested review from frankreno

@samjsong samjsong Awaiting requested review from samjsong

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel

@pmalek-sumo pmalek-sumo Awaiting requested review from pmalek-sumo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vsinghal13 @sumo-drosiek @perk-sumo