Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add forwarding kubelet_running containers and pods metrics #1118

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Add forwarding kubelet_running containers and pods metrics #1118

merged 1 commit into from
Nov 18, 2020

Conversation

sumo-drosiek
Copy link
Contributor

In k8s 1.19 kubelet_running_container_count and kubelet_running_pod_count has been renamed.

https://github.com/kubernetes/kubernetes/blob/b3fc8888631a43c21df159c395e560adf967be1f/CHANGELOG/CHANGELOG-1.19.md

Kubelet: following metrics have been renamed: kubelet_running_container_count --> kubelet_running_containers kubelet_running_pod_count --> kubelet_running_pods (#92407, @RainbowMango) [SIG API Machinery, Cluster Lifecycle, Instrumentation and Node]

@sumo-drosiek sumo-drosiek added this to the v2.0 milestone Nov 18, 2020
kasia-kujawa
kasia-kujawa approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@kasia-kujawa kasia-kujawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumo-drosiek sumo-drosiek merged commit 9845e9e into master Nov 18, 2020
@sumo-drosiek sumo-drosiek deleted the drosiek-k8s-kubelet-metrics branch November 18, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasia-kujawa kasia-kujawa kasia-kujawa approved these changes

@perk-sumo perk-sumo Awaiting requested review from perk-sumo

@pmalek-sumo pmalek-sumo Awaiting requested review from pmalek-sumo

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sumo-drosiek @kasia-kujawa