Bump versions of plugins used in Dockerfile #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lei-sumo
previously approved these changes
Aug 5, 2019
| @@ -179,7 +179,6 @@ data: | |||
| cache_size "#{ENV['K8S_METADATA_FILTER_BEARER_CACHE_SIZE']}" | |||
| cache_ttl "#{ENV['K8S_METADATA_FILTER_BEARER_CACHE_TTL']}" | |||
| tag_to_kubernetes_name_regexp '.+?\.containers\.(?<pod_name>[^_]+)_(?<namespace>[^_]+)_(?<container_name>.+)-(?<docker_id>[a-z0-9]{64})\.log$' | |||
| merge_json_log false | |||
There was a problem hiding this comment.
Why do need to remove this one?
There was a problem hiding this comment.
This parameter was removed in the newer version of kubernets_metadata plugin, from their README:
NOTE: As of the release 2.1.x of this plugin, it no longer supports parsing the source message into JSON and attaching it to the payload. The following configuration options are removed:
merge_json_log
preserve_json_log
samjsong
previously approved these changes
Aug 5, 2019
maimaisie
reviewed
Aug 5, 2019
| @@ -17,14 +17,13 @@ RUN apk add --no-cache --update --virtual .build-deps sudo build-base ruby-dev \ | |||
| && gem install snappy | |||
|
|
|||
| # FluentD plugins from RubyGems | |||
| RUN gem install fluent-plugin-s3 -v 1.1.4 \ | |||
There was a problem hiding this comment.
is this plugin not being used anywhere so we are removing it?
There was a problem hiding this comment.
It's not being used currently, but after talking with Frank we want to keep it around in case a customer wants to fork their data to S3 (and in the future GCP, Azure, etc.).
maimaisie
previously approved these changes
Aug 5, 2019
rvmiller89
dismissed stale reviews from maimaisie, samjsong, and lei-sumo
via
548968e
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
* Test if deleting fixes plan output * Remove dummy file * Test if deleting roles fixes plan output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed several of our fluentd plugin gems are out of date, and one is not being used.
Testing performed:
FYI: @lei-sumo @frankreno