Do not attach empty 'node' metadata #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzej-stencel
requested review from
frankreno,
kasia-kujawa,
perk-sumo,
pmalek-sumo and
sumo-drosiek
as code owners
|
Do you know why 'node' metadata is empty? |
I'm not quite sure, but I have a clue which I will want to investigate. There's a lot of 404 responses from Kubernetes API server which look a bit funny, like this: These responses are not something new, they occur in v1.2.1 as well. |
kasia-kujawa
approved these changes
Dec 23, 2020
pmalek-sumo
reviewed
Dec 28, 2020
There was a problem hiding this comment.
We'll need to cherry-pick this to https://github.com/SumoLogic/sumologic-kubernetes-fluentd
fluent-plugin-enhance-k8s-metadata/test/plugin/test_filter_enhance_k8s_metadata.rb
Outdated
Show resolved
Hide resolved
This was actually submitted by @astencel-sumo 🤦🏻 (SumoLogic/sumologic-kubernetes-fluentd#54) Thanks! |
pmalek-sumo
force-pushed
the
do-not-attach-empty-metadata
branch
from
cae2436 to
a2b5659
Compare
pmalek-sumo
force-pushed
the
do-not-attach-empty-metadata
branch
from
a2b5659 to
d706053
Compare
Some metrics might not have a specific |
pmalek-sumo
approved these changes
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After attaching
node=nilmetadata to a metrics record, the other pluginprometheus_formatfails with "undefined method `gsub' for nil:NilClass":long-collection-sumologic-fluentd-metrics-8 fluentd 2020-12-23 11:18:21 +0000 [warn]: #0 dump an error event: error_class=NoMethodError error="undefined method `gsub' for nil:NilClass" location="/usr/local/bundle/gems/fluent-plugin-prometheus-format-1.3.2/lib/fluent/plugin/filter_prometheus_format.rb:127:in `escape'" tag="prometheus.metrics.state" time=2020-12-23 11:18:14.000000000 +0000 record={"@metric"=>"kube_pod_container_resource_limits", "app"=>"collections", "container"=>"forge-metrics", "endpoint"=>"http", "instance"=>"10.3.71.116:8080", "job"=>"kube-state-metrics", "namespace"=>"long-distributed-systems", "pod"=>"forge-pod1-fd7c8b6d4-gtvdw", "prometheus"=>"long-collections/long-collection-prometheus", "prometheus_replica"=>"prometheus-long-collection-prometheus-0", "resource"=>"cpu", "unit"=>"core", "@timestamp"=>1608722294978, "@value"=>0.1, "cluster"=>"long", "prometheus_service"=>"long-prometheus-kube-state-metrics", "node"=>nil, "pod_labels"=>{"assembly"=>"forge", "assemblyVersion"=>"21.0-1606248095-4476-165371dae6bb", "chart"=>"sumo-assembly", "chartVersion"=>"1.0.1", "heritage"=>"Helm", "pod-template-hash"=>"fd7c8b6d4", "release"=>"long-forge", "sumoPod"=>"1", "sumoPodGroup"=>"ingestion", "team"=>"distributed-systems"}, "replicaset"=>"forge-pod1-fd7c8b6d4", "deployment"=>"forge-pod1"}