Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split metrics to multiple http sources #13

Merged
merged 3 commits into from
Apr 18, 2019
Merged

Split metrics to multiple http sources #13

merged 3 commits into from
Apr 18, 2019

Conversation

samjsong
Copy link
Contributor

We want to split metrics to multiple HTTP sources to prevent blacklisting. Synced with Frank about the more common jobs we'd want to separate out, which included:

apiserver
cadvisor
kubelet
kube-controller-manager
kube-scheduler
kube-state*
node-exporter
prometheus-operator-*

We still include a catchall http source for those metrics not belonging to any of the above jobs.

@frankreno @bin3377 @lei-sumo

FYI - @rvmiller89 @ggarg2906sumo

bin3377
bin3377 approved these changes Apr 17, 2019
View reviewed changes
Copy link

@bin3377 bin3377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lei-sumo
lei-sumo approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@lei-sumo lei-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable to me, left a question as i don't follow one part.

deploy/kubernetes/fluentd-sumologic.yaml
<match prometheus.datapoint>
@type rewrite_tag_filter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this part do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rewrite_tag_filter output plugin allows you to rewrite the tag for rerouting. In this case the plugin looks for the job and appends it to the already existing tag, which becomes prometheus.datapoint.<JOB>

@samjsong
Merge branch 'master' of github.com:SumoLogic/sumologic-kubernetes-co…
f9657d0 
…llection into ssong-split-metrics-multiple-sources
@samjsong samjsong merged commit 33db1de into master Apr 18, 2019
@samjsong samjsong deleted the ssong-split-metrics-multiple-sources branch April 18, 2019 20:10
@samjsong
Copy link
Contributor Author

samjsong commented Apr 18, 2019 •
edited
Loading

cc @ggarg2906sumo this PR has been merged, so now you will need multiple (nine) http sources on the sumo side. I've just pushed new Docker images containing the rewrite_tag_filter plugin that we need so you will need to delete your deployment and redo your fluentd setup

psaia pushed a commit to psaia/sumologic-kubernetes-collection that referenced this pull request May 25, 2021
@msuterski
Merge pull request SumoLogic#13 from nytimes/approve-adr-6
2af77e1 
Update ADR status to approved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bin3377 bin3377 bin3377 approved these changes

@lei-sumo lei-sumo lei-sumo approved these changes

@frankreno frankreno Awaiting requested review from frankreno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samjsong @lei-sumo @bin3377