Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 40 SHA chars in dev helm chart versions #1374

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

pmalek-sumo
Copy link
Contributor

Description

Because of ambiguous versions being produced (most likely caused by calling git describe on a repo with only one branch checked out on Github Actions link versus the same command being called on a full repo locally) let's use a longer version for our dev helm charts, i.e. 40 SHA characters.


Testing performed
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@pmalek-sumo pmalek-sumo merged commit dc0ee4b into main Jan 25, 2021
@pmalek-sumo pmalek-sumo deleted the use-40-chars-in-dev-helm-chart-version branch January 25, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants