Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move fluent-bit INPUT config to overrides yaml #140

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

samjsong
Copy link
Contributor

Description

Since the OOB fluent-bit helm chart does not expose configs for Refresh_Interval and Rotate_Wait, we decided to expose the [INPUT] config for fluent-bit explicitly in the overrides yaml file.

For reference, this was the helm chart's [INPUT] config. We need to keep .Values.input.systemd.enabled and .Values. trackOffsets in our overrides since they are used here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@INCLUDE fluent-bit-input.conf
@INCLUDE fluent-bit-output.conf

[INPUT]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will extraEntries.input help to expose the knobs we want?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately not. There's two issues with extraEntries.input:

  1. Since Refresh_Interval 5 is already hard coded in line 33, we cannot configure this parameter.
  2. Since extraEntries.input is on line 50, after the systemd section, any configuration will be inserted to the systemd section, not the tail section. So if we want to specify Rotate_Wait with extraEntries.input, we cannot use the systemd section (input.systemd.enabled must be set to false).

@samjsong samjsong merged commit 639f07c into master Aug 12, 2019
@samjsong samjsong deleted the ssong-fluentbit-input branch August 12, 2019 22:45
psaia pushed a commit to psaia/sumologic-kubernetes-collection that referenced this pull request May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants