fix labels, disable Fluent-Bit Helm Chart serviceMonitor, use Prometheus Operator additionalServiceMonitors to work around expectation that Prometheus Operator is already installed.

[frankreno]

fix labels, disable Fluent-Bit Helm Chart serviceMonitor, use Prometheus Operator additionalServiceMonitors to work around expectation that Prometheus Operator is already installed.

[lei-sumo]

We will also need to document to remind user to override all these hard corded value if they specify a different release name cc @maimaisie

[rvmiller89]

@frankreno I get this error trying this, maybe I'm doing something wrong?

k8s $ k get pods
No resources found.
k8s $ k get servicemonitors
No resources found.
k8s $ helm install sumologic/sumologic --name collection --namespace sumologic -f values.yaml --no-crd-hook
Error: release collection failed: servicemonitors.monitoring.coreos.com "collection-fluent-bit" already exists

Interestingly, fluentd and fluentbit do appear to work then, but only those 3 service monitors. The only targets I see in Prometheus now are

sumologic/collection-fluent-bit/0 (6/6 up) 
sumologic/collection-sumologic-events/0 (1/1 up) 
sumologic/collection-sumologic/0 (3/3 up) 

[maimaisie]

There is a bug in our CI script that if you change values.yaml in the first commit of a new branch, the overrides yamls don't get generated (tracked by this Jira https://jira.kumoroku.com/jira/browse/SUMO-117261 but I haven't got a chance to look into it yet). To workaround it, we'll need to make some changes in values.yaml in a second commit. Let me just add a newline somewhere and delete it later 😓

[rvmiller89]

Frank and I figured out the issue I was having with "collection-fluent-bit" already exists ...

The problem is that I was applying the new values.yaml over the repository helm chart, which still had the old fluent-bit service monitor declaration, so it was trying to declare the same service monitor twice. This will be resolved once we update the repository version.

[maimaisie]

@frankreno this file is generated from values.yaml. is this name: collection-fluent-bit correct for the prometheus-overrides.yaml file?