SUMO-117261: Skip using TRAVIS_COMMIT_RANGE for yaml detection #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvmiller89
force-pushed
the
rmiller-fix-yaml-detection-ci
branch
2 times, most recently
from
2c08dcb to
72b5318
Compare
rvmiller89
force-pushed
the
rmiller-fix-yaml-detection-ci
branch
from
72b5318 to
031566e
Compare
maimaisie
reviewed
Aug 30, 2019
ci/build.sh
Outdated
| git checkout $TRAVIS_BRANCH | ||
| fi | ||
|
|
||
| # Check for invalid changes to overrides yaml files |
There was a problem hiding this comment.
should this check be at the top like it was before? The reason we put it at the top is because we didn't want to build the gems or the image if it would fail here
There was a problem hiding this comment.
If we're okay with moving the # Set up Github part to the top too, I'm fine with having it fail faster. In my testing it wasn't a huge deal that it built the gems/docker image before failing.
maimaisie
approved these changes
Aug 30, 2019
lei-sumo
approved these changes
Aug 30, 2019
| echo "No changes in the generated overrides files." | ||
| fi | ||
| # Generate override yaml files for chart dependencies to determine if changes are made to overrides yaml files | ||
| echo "Generating overrides files..." |
There was a problem hiding this comment.
Do we always generate override files now?
There was a problem hiding this comment.
We do. We will only commit them if there is a difference detected, however.
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recommend using "Hide whitespace changes" since most of this is just indent change.
Rather than using
TRAVIS_COMMIT_RANGEwhich is empty on initial commit, we cangit diff master...$TRAVIS_BRANCHto detect manual changes to the yaml files.Rather than checking for changes made to
values.yaml, we can always generate the new files and commit them if there is a difference.Testing performed