-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kubelet, systemd filtration and refactor containers exporter #1772
Conversation
sumo-drosiek
commented
Sep 21, 2021
•
edited
Loading
edited
- unify exporting for systemd, collectd and containers logs
- add filtration for systemd like we already have in fluentd
- add kubelet pipeline
… in exporter Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
d875407
to
4cda8ac
Compare
deploy/helm/sumologic/values.yaml
Outdated
- attributes/remove_fluent_tag | ||
- filter/include_kubelet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually as I think of it now I believe we can swap those 2 to save processing of "non kubelet" entries, i.e. no need to remove the fluent.tag
from a record that will be filtered out anyway.
The same can be done for systemd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we should move it as far as possible, we have additional filtering in sourceprocessor for example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean "as far as possible"? Shouldn't we filter out as soon as possible in the pipeline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean moving - attributes/remove_fluent_tag
just before batch
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>