chore: bump Thanos image to our build of v0.23.1 #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanos upstream doesn't upload Docker images for arm64 to their registry yet. We're going to use our own image until that changes. The image is completely unmodified, using Thanos' own build process.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pmalek-sumo
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanos upstream doesn't upload Docker images for arm64 to their registry yet. We're going to use our own image until that changes. The image is completely unmodified, using Thanos' own build process.
I ran integration tests on this change in an ARM EKS cluster and they passed. Considering how little Thanos does for us, I think it's safe to merge this.
Checklist
Remove items which don't apply to your PR.
Testing performed