Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix otelcol agent template #1975

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Conversation

mat-rumian
Copy link
Contributor

Description

Fill in your description here.


Checklist

Remove items which don't apply to your PR.

  • Changelog updated
Testing performed

Tested on:

sumologic:
  accessId: "dummy"
  accessKey: "dummy"
  endpoint: http://receiver-mock.receiver-mock:3000/terraform/api/
  clusterName: "cluster-1"
  traces:
    enabled: true

otelagent:
  enabled: true

@mat-rumian mat-rumian requested a review from a team as a code owner December 13, 2021 17:02
@mat-rumian
Copy link
Contributor Author

There was an issue with envs key. After fix:

        env:
        - name: GOGC
          value: "80"
        - name: SUMO_ENDPOINT_DEFAULT_TRACES_SOURCE
          valueFrom:
            secretKeyRef:
              name: sumologic
              key: endpoint-traces
        - name: SUMO_ENDPOINT_DEFAULT_METRICS_SOURCE
          valueFrom:
            secretKeyRef:
              name: sumologic
              key: endpoint-metrics

before fix:

        env:
        - name: GOGC
          value: "80"
        
                - name: SUMO_ENDPOINT_DEFAULT_TRACES_SOURCE
                  valueFrom:
                    secretKeyRef:
                      name: sumologic
                      key: endpoint-traces
        - name: SUMO_ENDPOINT_DEFAULT_METRICS_SOURCE
          valueFrom:
            secretKeyRef:
              name: sumologic
              key: endpoint-metrics

@pmalek-sumo
Copy link
Contributor

How come our tests didn't catch that 😬 ?

@perk-sumo perk-sumo merged commit afe73c1 into main Dec 13, 2021
@perk-sumo perk-sumo deleted the mat-rumian-fix-otel-agent-template branch December 13, 2021 17:14
@perk-sumo perk-sumo changed the title Fix Otel Agent Template Fix otelcol agent template Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants