feat: add experimental otelcol log collector #1986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm
force-pushed
the
feat/otelcol-log-collector
branch
from
b87ac45 to
dc97a49
Compare
swiatekm
force-pushed
the
feat/otelcol-log-collector
branch
4 times, most recently
from
32209ee to
76d2776
Compare
Please create an issue for v3 as that will be a breaking change. Also this most probably will be changed globally for many other keys. |
perk-sumo
reviewed
Dec 17, 2021
perk-sumo
reviewed
Dec 17, 2021
I meant the internal keys defined in |
pmalek-sumo
suggested changes
Dec 17, 2021
swiatekm
force-pushed
the
feat/otelcol-log-collector
branch
from
76d2776 to
eb86894
Compare
swiatekm
commented
Dec 17, 2021
swiatekm
force-pushed
the
feat/otelcol-log-collector
branch
from
a517abd to
29209f0
Compare
perk-sumo
reviewed
Dec 17, 2021
perk-sumo
reviewed
Dec 17, 2021
perk-sumo
reviewed
Dec 17, 2021
swiatekm
force-pushed
the
feat/otelcol-log-collector
branch
2 times, most recently
from
65fbac4 to
6211128
Compare
|
@astencel-sumo maybe you can take a look as well? |
swiatekm
force-pushed
the
feat/otelcol-log-collector
branch
from
6211128 to
c4900a4
Compare
pmalek-sumo
reviewed
Jan 3, 2022
perk-sumo
approved these changes
Jan 3, 2022
swiatekm
force-pushed
the
feat/otelcol-log-collector
branch
from
c4900a4 to
2fb5464
Compare
pmalek-sumo
reviewed
Jan 3, 2022
pmalek-sumo
reviewed
Jan 3, 2022
This is an alpha feature without a stable API. It only supports container logs from docker-shim. Co-authored-by: Patryk Małek <pmalek@sumologic.com>
We're adding more pipelines that use otlp as a source, and we should be clearer about what kind of data each pipeline processes.
swiatekm
force-pushed
the
feat/otelcol-log-collector
branch
from
a03a07e to
4cc5971
Compare
pmalek-sumo
reviewed
Jan 5, 2022
pmalek-sumo
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an alpha feature without a stable API. It only supports container logs from docker-shim. Fluent-bit needs to be manually disabled to avoid duplicate logs.
The namespacing in the internal configuration is currently a bit messy - we have a top-level
sumologic.logskey, which should probably besumologic.metadata.logs, same with metrics. Same thing is true about the directory structure within the Helm chart. I'd like to change both of those in a separate PR after merging this one. Then this collector can live undersumologic.logs.*instead ofsumologic.logs.collector.*.The configuration for otelcol was originally prepared by @astencel-sumo, he gets credit for it actually doing the right thing.
Checklist
Remove items which don't apply to your PR.
Testing performed