Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): add metrics port to otelcol pods #1992

Merged
merged 2 commits into from
Dec 17, 2021

Conversation

pmalek-sumo
Copy link
Contributor

@pmalek-sumo pmalek-sumo commented Dec 17, 2021

This PR adds port 8888 (aka metrics) to otelcol's pods (both metrics and logs) so that it can be used to gather otelcol's metrics

This should actually be done already but it seems we missed this somehow. Our docs already mention this:

 `otelcol.metrics.enabled` | Enable or disable generation of the metrics from Collector.

@pmalek-sumo pmalek-sumo self-assigned this Dec 17, 2021
@pmalek-sumo pmalek-sumo force-pushed the otelcol-configurable-metrics-port branch from 54431ae to b10ef54 Compare December 17, 2021 15:00
@pmalek-sumo pmalek-sumo marked this pull request as ready for review December 17, 2021 15:07
@pmalek-sumo pmalek-sumo requested a review from a team as a code owner December 17, 2021 15:07
@pmalek-sumo pmalek-sumo force-pushed the otelcol-configurable-metrics-port branch from b10ef54 to 060dcfe Compare December 17, 2021 15:12
@pmalek-sumo pmalek-sumo changed the title feat(helm): add configurable otelcol metrics port fix(helm): add metrics port to otelcol pods Dec 17, 2021
@github-actions github-actions bot added the documentation documentation label Dec 17, 2021
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should actually be done already but it seems we missed this somehow.

I believe that was done for the tracing otelcol only. But there is no reason to add this to logs and tracing ones as well.

@pmalek-sumo pmalek-sumo enabled auto-merge (squash) December 17, 2021 15:19
@pmalek-sumo pmalek-sumo disabled auto-merge December 17, 2021 15:19
@pmalek-sumo
Copy link
Contributor Author

But there is no reason to add this to logs and tracing ones as well.

"there is no reason to add" or "there is no reason not to add"

?? @perk-sumo 🤔

@pmalek-sumo pmalek-sumo merged commit 925b4f8 into main Dec 17, 2021
@pmalek-sumo pmalek-sumo deleted the otelcol-configurable-metrics-port branch December 17, 2021 15:25
@perk-sumo perk-sumo added this to the v2.4 milestone Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants