Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fluentd.apiServerUrl property #2077

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

andrzej-stencel
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the documentation documentation label Feb 3, 2022
@andrzej-stencel andrzej-stencel force-pushed the api-server-url-property branch 3 times, most recently from 3d22f2b to 3d0b29b Compare February 3, 2022 10:18
@andrzej-stencel andrzej-stencel marked this pull request as ready for review February 3, 2022 10:30
@andrzej-stencel andrzej-stencel requested a review from a team as a code owner February 3, 2022 10:30
Comment on lines +8 to +10
{{- if $.Values.fluentd.apiServerUrl }}
kubernetes_url {{ $.Values.fluentd.apiServerUrl | quote }}
{{- end }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could convert it to template evnetually

Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Please consider moving code to template to avoid repetitions

@andrzej-stencel andrzej-stencel force-pushed the api-server-url-property branch from 3d0b29b to 6413f7b Compare February 3, 2022 11:27
@andrzej-stencel andrzej-stencel merged commit c701769 into main Feb 3, 2022
@andrzej-stencel andrzej-stencel deleted the api-server-url-property branch February 3, 2022 12:15
@perk-sumo perk-sumo added this to the v2.5 milestone Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants