Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(otelcol/metrics): do not add host to metrics #2085

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

sumo-drosiek
Copy link
Contributor

@sumo-drosiek sumo-drosiek commented Feb 3, 2022

Description

Do not add host dimension to metrics. If this is not set, it is set to otelcol name what is misleading


Checklist

Remove items which don't apply to your PR.

  • Changelog updated
Testing performed
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@sumo-drosiek sumo-drosiek requested a review from a team as a code owner February 3, 2022 14:00
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@sumo-drosiek sumo-drosiek force-pushed the drosiek-do-not-add-host-by-otelcol branch from e1795c1 to 97ef029 Compare February 3, 2022 14:37
@sumo-drosiek sumo-drosiek merged commit a7f9d26 into main Feb 3, 2022
@sumo-drosiek sumo-drosiek deleted the drosiek-do-not-add-host-by-otelcol branch February 3, 2022 14:56
@sumo-drosiek sumo-drosiek mentioned this pull request Feb 4, 2022
3 tasks
@perk-sumo perk-sumo added this to the v2.5 milestone Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants