Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add otelcol's liveness and readiness probes configuration #2105

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

pmalek-sumo
Copy link
Contributor

@pmalek-sumo pmalek-sumo commented Feb 9, 2022

This also changes the default settings to the following:

livenessProbe:
  periodSeconds: 10
  timeoutSeconds: 3
  failureThreshold: 3
readinessProbe:
  periodSeconds: 10
  timeoutSeconds: 3
  failureThreshold: 3

Default until now for otc:

livenessProbe:
  failureThreshold: 3
  httpGet:
    path: /
    port: 13133
    scheme: HTTP
  periodSeconds: 10
  successThreshold: 1
  timeoutSeconds: 1

For comparison fluentd probes are set like so:

livenessProbe:
  failureThreshold: 3
  httpGet:
    path: /fluentd.pod.healthcheck?json=%7B%22log%22%3A+%22health+check%22%7D
    port: 9880
    scheme: HTTP
  initialDelaySeconds: 300
  periodSeconds: 30
  successThreshold: 1
  timeoutSeconds: 3

@pmalek-sumo pmalek-sumo self-assigned this Feb 9, 2022
@pmalek-sumo pmalek-sumo force-pushed the otelcol-add-probes-configuration branch from 4b41661 to f63d625 Compare February 9, 2022 13:24
@swiatekm
Copy link

swiatekm commented Feb 9, 2022

timeoutSeconds: 1

In your changes, I see this set to 3. Which is the correct value?

Have you tested how this behaves under load?

@pmalek-sumo
Copy link
Contributor Author

timeoutSeconds: 1

In your changes, I see this set to 3. Which is the correct value?

Have you tested how this behaves under load?

@swiatekm-sumo please check again. Wrong wording in the description :)

@pmalek-sumo pmalek-sumo marked this pull request as ready for review February 9, 2022 13:51
@pmalek-sumo pmalek-sumo requested a review from a team as a code owner February 9, 2022 13:51
@pmalek-sumo pmalek-sumo force-pushed the otelcol-add-probes-configuration branch from f63d625 to a3d2c4e Compare February 9, 2022 13:53
@github-actions github-actions bot added the documentation documentation label Feb 9, 2022
@pmalek-sumo pmalek-sumo force-pushed the otelcol-add-probes-configuration branch from a3d2c4e to 0c925b0 Compare February 9, 2022 14:36
@pmalek-sumo pmalek-sumo added this to the v2.6 milestone Feb 9, 2022
@pmalek-sumo pmalek-sumo merged commit 55a4e5d into main Feb 9, 2022
@pmalek-sumo pmalek-sumo deleted the otelcol-add-probes-configuration branch February 9, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants