Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add fluentd buffers vs DPM calculations info for metrics #2128

Merged
merged 2 commits into from
Feb 15, 2022

Conversation

perk-sumo
Copy link
Contributor

Description

Fill in your description here.


Checklist

Remove items which don't apply to your PR.

  • Changelog updated
Testing performed
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@perk-sumo perk-sumo requested a review from a team as a code owner February 14, 2022 16:08
@github-actions github-actions bot added the documentation documentation label Feb 14, 2022
@perk-sumo perk-sumo force-pushed the perk-add-fluentd-buffers-calculation-info branch 5 times, most recently from 1dbdc16 to 3a4420d Compare February 14, 2022 16:30
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgTM. Do we not want to have a section for logs/events as well?

@swiatekm
Copy link

I think it'd be safer to divide the final values by 2 to account for uneven load on FluentD instances. Even with the remote write proxy, we're still relying on Kubernetes Service load balancing, which is far from perfect.

@perk-sumo perk-sumo force-pushed the perk-add-fluentd-buffers-calculation-info branch 2 times, most recently from 9658197 to 7c457c1 Compare February 15, 2022 10:03
@perk-sumo
Copy link
Contributor Author

I think it'd be safer to divide the final values by 2 to account for uneven load on FluentD instances.

Fair point, I've added that info and recommendation.

@perk-sumo
Copy link
Contributor Author

This lgTM. Do we not want to have a section for logs/events as well?

We didn't check that for logs or events so cannot give such info yet.

@perk-sumo perk-sumo added this to the v2.6 milestone Feb 15, 2022
@perk-sumo perk-sumo force-pushed the perk-add-fluentd-buffers-calculation-info branch 3 times, most recently from 2473f65 to 06f3030 Compare February 15, 2022 10:15
@perk-sumo perk-sumo force-pushed the perk-add-fluentd-buffers-calculation-info branch from 06f3030 to d2631b0 Compare February 15, 2022 10:19
@perk-sumo perk-sumo enabled auto-merge (rebase) February 15, 2022 10:19
@perk-sumo perk-sumo merged commit 8777d35 into main Feb 15, 2022
@perk-sumo perk-sumo deleted the perk-add-fluentd-buffers-calculation-info branch February 15, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants