fix: increase OTC liveness timeout and period #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm
force-pushed
the
fix/otc-liveness-timeout
branch
from
79193fc to
9fa4d0f
Compare
pmalek-sumo
approved these changes
Mar 1, 2022
sumo-drosiek
approved these changes
Mar 1, 2022
The current liveness probe doesn't actually check liveness in any meaningful way - it merely checks if the health_check extension is functional. We really don't want it to cause restarts under load, which it can with the current settings. Increase the timeout and period to mitigate this. We can revisit once the liveness check is more meaningful.
swiatekm
force-pushed
the
fix/otc-liveness-timeout
branch
from
9fa4d0f to
2aa1517
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current liveness probe doesn't actually check liveness in any meaningful way - it merely checks if the health_check extension is functional. We really don't want it to cause restarts under load, which it can with the current settings. Increase the timeout and period to mitigate this. We can revisit once the liveness check is more meaningful.
Checklist
Remove items which don't apply to your PR.
Testing performed